Define distance consistently as (x-y)^T*M*(x-y)
#60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
added 2 commits
May 23, 2017 11:25
Fixes the transformes returned by ITML and LSML.
The following now holds also for ITML, LSML, SDML and the covariance method:
learner.transformer().T.dot(learner.transformer()) == learner.metric()
Callidior
force-pushed
the
metric-transformer-harmonization
branch
from
d2d77c4 to
4555105
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, this fixes the transformers returned by ITML and LSML, improving their class-separation performance on the iris unit test:
The following now holds also for all learners, including ITML, LSML, SDML and the covariance method:
This PR fixes #57.